Jump to content

User talk:Gboyers/archive8: Difference between revisions

Line 348: Line 348:
:There are better ways of doing it than that. Yes, align=center is old-style HTML and ideally shouldn't be used (but it still pretty much works). the style="text-align:center" is CSS - but the whole point of CSS is that it can be applied to all galleries automatically from a [[Mediawiki:Common.css|stylesheet]] rather than having to define it every time. :I've added the neccessary CSS, so now [[Sandbox#Gallery_1|all galleries]] will be centred just by using <nowiki><gallery></nowiki> - no div or table is required. Let me know if that solves your problems. [[User:Gboyers|gboyers]] <sup>[[User_talk:Gboyers|talk]]</sup> 12:23, 21 October 2011 (BST)
:There are better ways of doing it than that. Yes, align=center is old-style HTML and ideally shouldn't be used (but it still pretty much works). the style="text-align:center" is CSS - but the whole point of CSS is that it can be applied to all galleries automatically from a [[Mediawiki:Common.css|stylesheet]] rather than having to define it every time. :I've added the neccessary CSS, so now [[Sandbox#Gallery_1|all galleries]] will be centred just by using <nowiki><gallery></nowiki> - no div or table is required. Let me know if that solves your problems. [[User:Gboyers|gboyers]] <sup>[[User_talk:Gboyers|talk]]</sup> 12:23, 21 October 2011 (BST)


::Actually, making galleries centered by default seems to be a bad idea. Not all galleries need to be centered, like in the vehicle image pages ([[:File:Admiral-GTAVC-LooseEnds-front.jpg]]). I added style="text-align:center" within the galleries tag for the identical effects.--'''[[User:Spaceeinstein|spaceeinstein]]''' 16:28, 21 October 2011 (BST)
Actually, making galleries centered by default seems to be a bad idea. Not all galleries need to be centered, like in the vehicle image pages ([[:File:Admiral-GTAVC-LooseEnds-front.jpg]]). I added style="text-align:center" within the galleries tag for the identical effects.--'''[[User:Spaceeinstein|spaceeinstein]]''' 16:28, 21 October 2011 (BST)


::Did you meant to revert revision on common.css and not common.js? My edits on common.js included the fix to the duplicate show/hide text in collapsible tables.--'''[[User:Spaceeinstein|spaceeinstein]]''' 18:16, 21 October 2011 (BST)
Did you meant to revert revision on common.css and not common.js? My edits on common.js included the fix to the duplicate show/hide text in collapsible tables.--'''[[User:Spaceeinstein|spaceeinstein]]''' 18:16, 21 October 2011 (BST)
 
:Yes, you removed all the CSS for navboxes, which (when hard refreshed) broke them completely (they didn't collapse at all). I'll look into it. [[User:Gboyers|gboyers]] <sup>[[User_talk:Gboyers|talk]]</sup> 19:34, 21 October 2011 (BST)
Cookies help us deliver our services. By using our services, you agree to our use of cookies.